angular-ui/ui-grid

Prefix i18nService to avoid conflicts

Open

#6,290 opened on Jun 29, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
breakinggood first issue

Description

Hello there,

I have an i18nService in my app. With ui-grid, wich also has an i18nService, both conflicts and it seems my only solution for now is to rename my service... crapy.

As a lib, is this possible to rename i18nService to uiGridI18nService ?

  • This is a bug report, not a question on how to use the grid.
    Use Stack Overflow or Gitter for questions.
  • You have searched the open issues to see if this bug has been filed before. We don't want duplicate issues.
  • You have reviewed the tutorials and documentation to ensure you are using the grid correctly. ui-grid.info
  • You are using the latest version of the grid. Older versions are not patched or supported.
  • You have provided steps to recreate your bug. A plunkr is even better.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS service basicsCodebase navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests renaming `i18nService` to `uiGridI18nService` to avoid name collisions. Start by locating all instances of `i18nService` in the source code, likely in `/src`. Rename the service definition and all references, and consider adding backward compatibility.