angular-ui/ui-grid

getTotalPages() is working wrong for Custom pagination

Open

#6,246 opened on Jun 2, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Hi guys, In this Pagination api method below

getTotalPages: function () { if (!grid.options.enablePagination) { return null; } if (grid.options.useCustomPagination) { return grid.options.paginationPageSizes.length; } return (grid.options.totalItems === 0) ? 1 : Math.ceil(grid.options.totalItems / grid.options.paginationPageSize); }

in this part:

if (grid.options.useCustomPagination) { return grid.options.paginationPageSizes.length; }

It brokes the pagination, since it will never return the real quantity of pages to use, but the quantity in the pageSizes array ....

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptAngularJS awareness
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The bug is in the getTotalPages() function, likely in ui grid's source file (e.g., src/js/core/factories/Grid.js). The current code returns grid.options.paginationPageSizes.length for custom pagination, which is incorrect. The fix should calculate the actual total pages, possibly using grid.options.totalItems and paginationPageSize, or retrieving the page count from backend if available. Examine how custom pagination is intended to work and replace the return statement accordingly.