angular-ui/ui-grid

Grid is build twice for each data-change when fastWatch is enabled

Open

#6,172 opened on Apr 24, 2017

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedseverity: performance

Description

Can be observed on the tutorial page: http://ui-grid.info/docs/#/tutorial/404_large_data_sets_and_performance

Due to these lines (https://github.com/angular-ui/ui-grid/blob/19455276ace7eef5c8dab8f719c17d7c4c31ae3a/src/js/core/directives/ui-grid.js#L56-L57) assigning a new array to the data property rebuilds the rows twice for the same change.

This has a major impact on load times of the grid, when complex rowProcessors are registered (treeBase, sort, etc.)

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSJavaScriptui grid architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the lines 56-57 in src/js/core/directives/ui grid.js where a new array assignment triggers double rebuild. Understand the fastWatch mechanism and how data changes are propagated. Propose a fix to avoid rebuilding rows twice. Check for any existing tests for this behavior.
Grid is build twice for each data-change when fastWatch is enabled · angular-ui/ui-grid#6172 | Good First Issue