angular-ui/ui-grid

expandable unusable state

Open

#6,164 opened on Apr 19, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedseverity: performance

Description

The expandable grid gets into an unusable state when you expand a bottom row and scroll up.

This issue is more pronounced on my local project which has a sub-grid with many rows. It can be reproduced on the UI Grid tutorial page by expanding a couple bottom rows:

Go to expandable grid tutorial page: http://ui-grid.info/docs/#/tutorial/216_expandable_grid Scroll to the bottom and expand the last two rows, 498 and 499. Start scrolling up. Notice that half the rows are now missing and they do not return until scrolling. All the way back down to the bottom. Example from the tutorial.

Updated: Link to tutorial was incorrect (original was http://ui-grid.info/docs/#/tutorial/306_expandable_grid)

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
This bug occurs when expanding bottom rows and scrolling, causing rows to go missing. To fix, investigate the grid's virtual scrolling and row expansion logic. Look at the expandable grid tutorial example and the relevant source files in the ui grid repository, particularly the uiGridExpandable module and gridUtil for row height and viewport updates. Recreate the steps and trace the behavior to identify where the row visibility calculation fails.
expandable unusable state · angular-ui/ui-grid#6164 | Good First Issue