angular-ui/ui-grid

Touchscreen scolling + selection conflict

Open

#6,147 opened on Apr 4, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, I am using ui-grid (v4.0.2 - 2016-12-30) with a linux touchscreen device, running chrome. My setup includes the following:

enableColumnMenus: false, enableFiltering: false, enableExpandableRowHeader: false, expandableRowTemplate: 'orderActions.html', expandableRowHeight: 35, enableRowSelection : true, selectionRowHeaderWidth: 0, enableFullRowSelection: true, multiSelect: false,

also, I expand a row upon selection. Everything works fine on a normal with mouse, but when I use the touchscreen to scroll, sometimes (especially on momentum scrolling action) rows are being selected when I only intend to scroll (drag).

Contributor guide

Research direction
Investigate touch event handling in ui grid's row selection logic. Look for conflicts between scrolling and selection events, particularly how touchstart and touchend are used. Consider debouncing or distance based thresholds to differentiate scroll from select.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50