angular-ui/ui-grid

Column width by percentage does not account for selection column

Open

#6,093 opened on Mar 17, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Expected Behavior When defining columns with percentage widths, if the columns defined in gridOptions.columnDefs add up to a total of 100%, they will fill up and not overflow the grid viewport.

Actual Behavior If ui-grid-selection is being used, the columns will overflow the grid viewport by the width of the selection column.

The selection column is a part of the grid control itself and not the data display, as evidenced by not being defined in columnDefs, so its size should be accounted for when calculating the size of the viewport, much like the vertical scroll bar is.

This plunker illustrates the issue by defining one 100% width column in a selectable grid: http://plnkr.co/edit/BcV3qI64mMOnNMdDAjPM?p=preview

You will have to enter app.js and change enableRowHeaderSelection to false to see that the sizing is correct when the selection row header is removed, as indicated by the comment there. (I tried to wire up a button to do this, but couldn't get the grid to recognize the change.)

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of AngularFamiliarity with ui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is about the selection column width not being accounted for when calculating column widths using percentage values. The plunker at http://plnkr.co/edit/BcV3qI64mMOnNMdDAjPM?p=preview demonstrates the problem. Investigate the grid's column sizing logic, likely in the core grid files, to see how the selection column width is excluded from the total width calculation. The fix should ensure that the selection column's width is considered when distributing percentage based column widths, similar to how the vertical scroll bar is accounted for.