angular-ui/ui-grid

Removing a row when all are expanded, everything will collapse leaving the button as "-" (expanded)

Open

#6,032 opened on Feb 21, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I have a grid with 2 levels with expandable options and delete rows for the first level grid. After delete any row, the data is reloaded, its ok if everything is collapsed, the issue is : the button is showing "-" instead of "+" Steps:

  1. Expand all rows image
  2. Delete 1 row image
  3. The grid is reloaded and the button is "-" image

Plunker: http://plnkr.co/edit/TJFaWv2KERcEZghz6scj?p=preview

Contributor guide

Research direction
Investigate the state management of row expansion in ui grid, specifically how the icon toggle (expand/collapse) is updated after a row deletion triggers data reload. Look at the grid's internal state reset mechanism.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65