angular-ui/ui-grid

Removing a row when all are expanded, everything will collapse leaving the button as "-" (expanded)

Open

#6,032 opened on Feb 21, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

I have a grid with 2 levels with expandable options and delete rows for the first level grid. After delete any row, the data is reloaded, its ok if everything is collapsed, the issue is : the button is showing "-" instead of "+" Steps:

  1. Expand all rows image
  2. Delete 1 row image
  3. The grid is reloaded and the button is "-" image

Plunker: http://plnkr.co/edit/TJFaWv2KERcEZghz6scj?p=preview

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic familiarity with AngularJSUnderstanding of ui grid expand/collapse
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue involves a state inconsistency when deleting a row after expanding all rows. Investigate the Plunker link (http://plnkr.co/edit/TJFaWv2KERcEZghz6scj?p=preview) and the ui grid source code, particularly the expand/collapse toggle logic and the data reload mechanism after deletion. Look at how the grid resets the expand state when the data changes. The bug likely lies in the toggle state not being re evaluated after the grid data is refreshed.