angular-ui/ui-grid

Style error when using editable number field and footer

Open

#5,999 opened on Feb 7, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

mistake When I use the edit feature of the ui-grid and I want to use a footer, there is something wrong in the style after editing.

I used 401 All Features example and I only modified the Age field in order to be a number type. When I edit any Age number pressing the arrows, the ui-grid styles are wrong.

I suspect that there is some mistake at ui-grid method: GridRenderContainer.prototype.needsHScrollbarPlaceholder, but I could not figure this out. If you have any recommendation it will be really useful for me.

Regards.

Here is my plunkr.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS basicsui grid conceptsCSS debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Reproduce the bug by editing the Age field in the provided Plunkr (http://plnkr.co/edit/aoXAhysDSbi9jv1wuMZK?p=preview). Investigate the method GridRenderContainer.prototype.needsHScrollbarPlaceholder as suspected. Check if the issue persists in the latest version of ui grid. Review the grid's rendering lifecycle and CSS for footer and editable cells.