angular-ui/ui-grid

Style error when using editable number field and footer

Open

#5,999 opened on Feb 7, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

mistake When I use the edit feature of the ui-grid and I want to use a footer, there is something wrong in the style after editing.

I used 401 All Features example and I only modified the Age field in order to be a number type. When I edit any Age number pressing the arrows, the ui-grid styles are wrong.

I suspect that there is some mistake at ui-grid method: GridRenderContainer.prototype.needsHScrollbarPlaceholder, but I could not figure this out. If you have any recommendation it will be really useful for me.

Regards.

Here is my plunkr.

Contributor guide

Research direction
Inspect the CSS and JavaScript related to the editable number field and footer in ui grid. Focus on the needsHScrollbarPlaceholder method in GridRenderContainer and adjust styles to prevent layout shift after editing.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70