angular-ui/ui-grid

In IE, shift-click secondary sorting works, but also selects all items on page.

Open

#5,952 opened on Jan 17, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
Browser IEgood first issue

Description

When shift-clicking on multiple sortable columns in Internet Explorer (I use IE11), text selection occurs as well.

This can be observed by executing the demo in the tutorial within IE:

ui-grid.info/docs/#/tutorial/102_sorting

Chrome works as expected. Haven't tried other browsers.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic AngularJS knowledgeUnderstanding of browser event handlingAbility to test in IE11
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the sorting click handler in the UI Grid source code to see how shift click events are processed. Look for event.preventDefault() usage. The demo page uses tutorial sorting. Likely in the angular ui/ui grid repository, the sorting feature is implemented in files like src/features/sort/js/sort.js or similar. Check for existing tests for shift click behavior across browsers.
In IE, shift-click secondary sorting works, but also selects all items on page. · angular-ui/ui-grid#5952 | Good First Issue