angular-ui/ui-grid

In IE, shift-click secondary sorting works, but also selects all items on page.

Open

#5,952 opened on Jan 17, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
Browser IEgood first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When shift-clicking on multiple sortable columns in Internet Explorer (I use IE11), text selection occurs as well.

This can be observed by executing the demo in the tutorial within IE:

ui-grid.info/docs/#/tutorial/102_sorting

Chrome works as expected. Haven't tried other browsers.

Contributor guide

Research direction
Investigate the event handler for shift click on column headers. In IE, the default text selection behavior is not prevented during secondary sorting. Locate the mousedown or click event listener and ensure event.preventDefault() is called to prevent text selection, while preserving the shift click sorting functionality.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJavaScriptIE compatibility testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30