angular-ui/ui-grid

ui-grid causing too many DOM reflows on IE11

Open

#5,855 opened on Dec 7, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (2,496 forks)batch import
Browser IEhelp wantedseverity: performance

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When a redraw is called for the grid, it calls elementHeight which calls the swap function on the pagination control (even if the controls are disabled by enablePaginationControls: false).

swap then iterates through a list of properties causing a reflow each time.

On IE11 this happens a large number of times effectively stalling the main thread.

There should be no need to call any kind of DOM reads/writes for this if enablePaginationControls == false,

Contributor guide

Research direction
Identify where enablePaginationControls is checked and skip DOM reads/writes in swap when it's false.
Tech stack
javascriptangular
Domain
frontendperformance
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40