angular-ui/ui-grid

Url in cellTemplate causes 2 invalid get requests

Open

#5,820 opened on Nov 17, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If I have cellTemplate: '< div class="ui-grid-cell-contents">< img src="{{ COL_FIELD }}"/>< /div >'

I get these invalid get requests when the grid initialises: GET https://127.0.0.1/%7B%7B%20grid.getCellValue(row,%20col)%20%7D%7D 404 (Not Found) GET https://127.0.0.1/%7B%7B%20COL_FIELD%20%7D%7D 404 (Not Found)

Which causes havoc with our error stats. Apart from that everything works fine and images are displayed correctly. If I remove the img tag I can see that all my urls are correct:

cellTemplate: '< div class="ui-grid-cell-contents" >{{ COL_FIELD }}< /div >'

Contributor guide

Research direction
Investigate why the img tag in cellTemplate triggers GET requests before Angular interpolates the template. The browser attempts to load the src attribute value before Angular compiles the template. A potential fix is to ensure the template is not parsed by the browser before Angular processes it, perhaps by using a different approach like a custom directive or sanitizing the template.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularJSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65