angular-ui/ui-grid

Fixes issue of eventOrigin not getting passed to begin edit when edit mode is triggered by cellNav

Open

#5,799 opened on Nov 9, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Fixes an issue where when ALL FEATURES are applied to grid and enableCellEditOnFocus is set to true the edit event would not pass the event to the beginEdit method causing issues with custom editors that rely on the type of event that triggered the cell into edit mode.

Take a look at the comments in the ui-custom-editor.js file.

http://plnkr.co/edit/FCqb3G5I70hyE2JrPFhN?p=preview

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularUI Grid custom editors
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that eventOrigin is not passed to beginEdit when edit mode is triggered by cellNav. Look at the custom editor in ui custom editor.js, and the plnkr link: http://plnkr.co/edit/FCqb3G5I70hyE2JrPFhN?p=preview. The fix likely involves ensuring that the event object is correctly forwarded. Check how cellNav triggers edit and compare with other triggers.