angular-ui/ui-grid

Export options not visible on menu intermittently

Open

#5,788 opened on Nov 4, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

On my project I have 2 tables on a page and I was finding that randomly the export options would be missing from the menu of one or both the tables. I found the solution was to increase the delay:

` module.service('uiGridExporterService', ['$q', 'uiGridExporterConstants', 'gridUtil', '$compile', '$interval', 'i18nService', function ($q, uiGridExporterConstants, gridUtil, $compile, $interval, i18nService) {

  var service = {

    delay: 1000,

`

because when the code gets here: $interval( function() { if (grid.api.core.addToGridMenu){ service.addToMenu( grid ); } }, this.delay, 1); sometimes addToGridMenu is still undefined and the export options are not added to the menu

Contributor guide

Research direction
Locate uiGridExporterService in the source code and increase the delay property (e.g., from 1000 to 2000) to ensure addToGridMenu is defined before adding export options to the menu.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70