angular-ui/ui-grid

Export options not visible on menu intermittently

Open

#5,788 opened on Nov 4, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

On my project I have 2 tables on a page and I was finding that randomly the export options would be missing from the menu of one or both the tables. I found the solution was to increase the delay:

` module.service('uiGridExporterService', ['$q', 'uiGridExporterConstants', 'gridUtil', '$compile', '$interval', 'i18nService', function ($q, uiGridExporterConstants, gridUtil, $compile, $interval, i18nService) {

  var service = {

    delay: 1000,

`

because when the code gets here: $interval( function() { if (grid.api.core.addToGridMenu){ service.addToMenu( grid ); } }, this.delay, 1); sometimes addToGridMenu is still undefined and the export options are not added to the menu

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic Angular knowledgeUnderstanding of ui grid event lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about the export options not appearing due to addToGridMenu being undefined when the interval fires. The proposed fix is to increase the delay in the uiGridExporterService from 1000ms to a larger value. To properly fix this, investigate the exporter service source code (likely uiGridExporterService) and determine if there is a more reliable way to wait for the grid API to be ready, such as waiting for a specific event or using a promise. Also, check if there are any related PRs or comments addressing this.
Export options not visible on menu intermittently · angular-ui/ui-grid#5788 | Good First Issue