angular-ui/ui-grid

Celledit makes changes on all cells after edit and cellNav

Open

#5,742 opened on Oct 14, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

I have a grid with cellNav enabled. I also have the enableCellEditOnFocus and the cellTemplate set on 'ui-grid/cellEditor'

When I enter the cell and edit it, everything goes well. Then I tab to the next field and enter new text -> repeating these steps. Now, when you press leave the grid / unFocus the cells and you press another key on the keyboard (p) all the fields that you previously entered are filled with this value.

See plunker: http://plnkr.co/edit/3esyAJ05giDjjsETxjPT?p=preview

Steps:

  1. Enter field and start typing.
  2. Navigate to next few input fields by pressing the 'tab' key and enter a value
  3. Leave the grid by clicking the mouse outside the form or set the focus on a non editable field
  4. Press the letter 'T' on the keyboard result: All previously entered fields are filled with 'T'

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsui grid usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
The issue describes a bug where after editing multiple cells via tab navigation and then pressing a key outside the grid, all previously edited cells get filled with that key. The provided plunker (http://plnkr.co/edit/3esyAJ05giDjjsETxjPT?p=preview) is key to reproduction. Investigate the cell edit event handling and focus management in the cellEditor and cellNav directives. Look for how the grid handles blur events and keypresses after editing.
Celledit makes changes on all cells after edit and cellNav · angular-ui/ui-grid#5742 | Good First Issue