angular-ui/ui-grid

CellNav prevents menu from closing

Open

#5,734 opened on Oct 11, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When cellNav is turned on, it has a stopPropogation on the cell element that prevents the grid/column menu from closing.

To see any example, go to the cellNav tutorial: http://ui-grid.info/docs/#/tutorial/202_cellnav

navigate through some cells, open up a menu, then click away from the menu

Result: the menu remains open Expected Result: the menu would close

This is due to the stopPropogation in the cellNav click event:

https://github.com/angular-ui/ui-grid/blob/master/src/features/cellnav/js/cellnav.js#L1044-L1045

This prevents the menu hide event from occurring:

https://github.com/angular-ui/ui-grid/blob/master/src/js/core/directives/ui-grid-menu.js#L111

What is the need/reason behind the stopPropogation in cellNav?

Contributor guide

Research direction
Inspect the stopPropagation call in cellnav.js line 1044-1045 and determine if it can be removed or conditionally applied to allow the menu hide event to propagate.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75