angular-ui/ui-grid

[BUG] When enableFullRowSelection: true, rowSelectionChanged on tablet called twice and the select row is not the correct one

Open

#5,709 opened on Sep 30, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi,

I am using your library in my web application. I set enableFullRowSelection: true. When I testing on tablets (IPAD, Nexus 7) the rowSelectionChanged will called twice. and sometimes when I select one row, but the selection will move to above one or bottom one, no the one I selected.

The following is my code: $scope.gridOptions = { enableSorting: true, enableRowSelection: true, enableRowHeaderSelection: false, enableFullRowSelection: true, noUnselect: true, multiSelect: false, onRegisterApi: function (gridApi) { gridApi.selection.on.rowSelectionChanged($scope, function (selectedRow) { alert("onRowSelectionChanged: " + selectedRow); console.log("AnnotationsController.js, rowSelectionChanged"); $scope.selectedAnnotation = selectedRow.entity; }); $scope.gridapi = gridApi; },

I also set .ui-grid-cell.ui-grid-disable-selection.ui-grid-row-header-cell { pointer-events: none; } in my css.

Thanks in advance!

Contributor guide

Research direction
Investigate why rowSelectionChanged fires twice on tablets. Check event listeners for touch and click, and verify full row selection logic. Reproduce with a tablet simulator and inspect the row selection handling code.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70