angular-ui/ui-grid

saveState (in Demo) reselects incorrect rows after sorting (related to: #5663)

Open

#5,706 opened on Sep 29, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

To reproduce:

  1. go: http://ui-grid.info/docs/#/tutorial/208_save_state
  2. select first three rows
  3. click Save
  4. sort on first column
  5. click Restore

Result: the incorrect three rows are selected.

Observation: as noted in #5663, suspect the use of row indexes is the cause of this issue.

Further: With external pagination, selection or sorting this issue is compounded.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate how row indexes are used in saveState and restoreState functions. The issue references #5663 which likely highlights similar problems with row indexes. Look into the demo code at the tutorial link and the ui grid source for state saving logic. A fix would involve using unique row identifiers instead of indexes.