angular-ui/ui-grid

saveState (in Demo) reselects incorrect rows after sorting (related to: #5663)

Open

#5,706 opened on Sep 29, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

To reproduce:

  1. go: http://ui-grid.info/docs/#/tutorial/208_save_state
  2. select first three rows
  3. click Save
  4. sort on first column
  5. click Restore

Result: the incorrect three rows are selected.

Observation: as noted in #5663, suspect the use of row indexes is the cause of this issue.

Further: With external pagination, selection or sorting this issue is compounded.

Contributor guide

Research direction
Investigate how row indexes are used during saveState and restore, especially after sorting. Check the linked issue #5663 for context. Look at the saveState feature code to see if it stores row references by index instead of unique identifiers.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AngularGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75