angular-ui/ui-grid

Async row removal does not work with inline edit

Open

#5,649 opened on Aug 26, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We remove large amounts of data by a background worker and we reflect this on ui-grid. So rows might be removed without any user action (just the refresher which runs in background notices that row is no longer present in database, it is also removed from grid immediately).

The problem is that if user is inline editing any row BELOW such removed row, inline edit still keeps old index.

I have created a plunkr to demonstrate the issue: http://plnkr.co/edit/I8KnXLCxeDiKQq5OR9lC?p=preview

Steps to reproduce:

  1. Start inline edit of second row immediately (e.g. change name and remain in inline edit mode)
  2. After 10 seconds first row is automatically removed
  3. Observe that row with the same index is in edit mode, but actually edited row is moved up. So user is editing another row.

Contributor guide

Research direction
Reproduce the issue using the provided Plunkr, then trace the inline edit index handling when rows are removed asynchronously.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75