angular-ui/ui-grid

Treebase getRowChildren returning wrong results

Open

#5,632 opened on Aug 18, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

The getRowChildren() function on the treebase control seems to be returning unexpected rows when a row processor is registered for filtering. The issue can be reproduced in the following plunker. http://plnkr.co/edit/xHfc63yZWdgr1O3qYjIm

On the plunker, type "josh" and press the "Log First Group Visible Rows" button. Notice that in the console, 3 rows will be logged, 2 of which actually belong to the first group, but you will notice that there is an entity in there that isn't even a part of this group, yet getRowChildren is stating that this is a child of that row.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of AngularJSFamiliarity with ui gridBasic debugging skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the treebase module of angular ui/ui grid, focusing on the getRowChildren function. Reproduce the bug using the provided plunker to confirm the behavior. Trace the logic when a row processor for filtering is registered, and check the row processing pipeline to understand how rows are filtered. Look for existing tests or related issues that might provide context.