angular-ui/ui-grid

A problematic watch

Open

#5,583 opened on Jul 26, 2016

View on GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedseverity: performance

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Please pay attention that such watches as ng-style=\"{ 'margin-left': colContainer.getMargin('left') + 'px'
on line 28204

that calls the following method on each digest cycle GridRenderContainer.prototype.getMargin = function getMargin(side)

create a huge overhead.

Contributor guide

Research direction
Inspect the ng style binding in the template and trace the getMargin method to understand the overhead.
Tech stack
javascript
Domain
frontend
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50