angular-ui/ui-grid

Sorting is broken when grid is expanded. App is stuck!

Open

#5,562 opened on Jul 19, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Hi all,

We have been using ui-grid (http://ui-grid.info/docs/#/tutorial/216_expandable_grid) in our project and currently facing with the following issue. I understand that expandable feature is still in alpha release.

Issue: Sorting is broken when grid is expanded and the grid becomes non-responsible.

Here's the plunker for reference: http://plnkr.co/edit/JvCwjInAFlzKnhjs51FR?p=preview

Steps to reproduce:

  1. As soon as the grid is loaded, expand all elements by clicking on "Expand All" button or "+" icon.
  2. Start sorting by "Dateofservice" column (2nd column).
  3. Grid/app is frozen with the exception Uncaught Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!

Notes:

  1. When the grid is not expanded, sorting by all columns (including second column) is working without any issues.
  2. After all nested grids are expanded, if I start sorting by any other column except the 2nd column and sort by 2nd column next, no issues. Everything works fine.
  3. If I sort by 2nd column by expanding only one or two first nested grids, leaving all other grids in collapsed mode, sorting works without any problem.
  4. This could be a bug or data issue. To be consistent with the expandable tutorial we are using complex.json data structure and have added couple extra data.

Can you please take a look into this issue and let me know your thoughts and comments?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSui grid expandable featureJavaScript debugging$digest cycle understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Examine the sorting implementation in ui grid's expandable feature, particularly the interaction between expandable rows and column sorting. Review the provided Plunker to reproduce the issue. Check the grid's internal digest cycle management to identify why sorting a specific column after expanding all rows causes infinite digests. Look at the sort logic in the source code (likely in src/features/expandable/ or similar) and compare with the working case of sorting when not expanded. Consider if the issue arises from watch expressions or data changes triggered by expanding rows.