angular-ui/ui-grid

regression on grid cell edit - $parse() throws errors

Open

#5,520 opened on Jul 5, 2016

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

I have recently updated to ui-grid 3.2.1 from 3.1.1. After upgrade I started getting $parse() throwing error while parsing the grid values that was working perfectly fine before upgrade.

When I compared the code I found this change between the versions -

version 3.1.1 - (line 15117 in addAriaLiveRegion function) values.push(currentSelection[i].getIntersectionValueFiltered());

version 3.2.1 - (line 15208 in addAriaLiveregion function) values.push(grid.getCellDisplayValue(currentSelection[i].row, currentSelection[i].col));

If I disable the cellNav feature, the error vanishes. So I thought of filing a regression bug here.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsunderstanding of ui grid cell editing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the addAriaLiveRegion function in the grid source code to compare the implementations of getIntersectionValueFiltered versus getCellDisplayValue. The change appears to have introduced a regression where $parse throws errors during cell editing. Check the related cellNav feature to understand the context of the intersection values. Look for any recent commits that changed this function. The specific lines are around 15117 in 3.1.1 and 15208 in 3.2.1.