angular-ui/ui-grid

Disabling a row doesn't disable cell edit

Open

#5,494 opened on Jun 26, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuetype: enhancement

Description

Have an issue on gridOptions.isRowSelectable. I see that though the row is disabled for select, the cell edit still works on it. I couldn't find for an option where I can disable the row completely. colDefs.cellEditableCondition doesn't seem to work on data, i.e., based on the value of a cell in a row, enable/disable cell. Am I missing something here? Is there a straightforward way to dynamically achieve complete row disable (select and edit)? If no (I searched and couldn't find), then I feel this is a bug and isRowSelectable=false should override cellEdit and disable cellEdit as well.

I created a plunker from the original example for row selection. The moment I add ui-grid-cellNav ui-grid-edit ui-grid-row-edit, row select option seems to be overridden. I feel it should be the opposite as I have explained above. http://plnkr.co/edit/y3ZwcJTrFzl9ApRuNmyg?p=preview

Note: Click on Set Selectable button in the example for the row selection condition to set in.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSui grid basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Reproduce the issue using the provided Plunker. Look at the source code in the ui grid repository for where `isRowSelectable` is evaluated and where cell editing is allowed per row. The fix would likely involve checking the row's selectability in the cell edit logic and preventing editing for rows that are not selectable. Review the grid options and events to ensure consistency.