angular-ui/ui-grid

Row virtualization is working incorrectly in expandable grid

Open

#5,475 opened on Jun 17, 2016

View on GitHub
 (3 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedneeds: analysis

Description

When using expandable grid the row virtualization is not taking into account that rows may be expanded. If any row is expanded, the additional space is left at the end of the grid. If last row is expanded, the expanded data may be not visible.

Steps to reproduce:

  1. Go to expandable example (http://ui-grid.info/docs/#!/tutorial/216_expandable_grid)
  2. Expand some rows in the first grid and scroll to the bottom - empty space is added.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptAngularJSUI Grid library basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the row virtualization code in ui grid, likely in files related to grid rendering and row expansion. Look at the expandable grid tutorial example to understand the expected behavior. Check any existing comments or linked PRs for attempted fixes. The issue is assigned, so clarify with the assignee if the fix is still needed.
Row virtualization is working incorrectly in expandable grid · angular-ui/ui-grid#5475 | Good First Issue