angular-ui/ui-grid

Sorting doesn't work with cellFilter and customTreeAggregationFinalizerFn for 'number'

Open

#5,405 opened on May 16, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

http://ui-grid.info/docs/#/tutorial/209_grouping

In the tutorials there is an example for doing a cellFilter for 'Balance' that will still work for aggregation. It's not apparent from the provided data (since they are all in the thousand range), but sorting doesn't work correctly for that column. It sorts it in lexicographical order instead of numerical order. I've tried with the number filter in angular as well.

I tried adding the type: 'number', which makes the sorting work, but breaks the aggregation total.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptAngularJSui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the ui grid source code, particularly the grouping and sorting modules. Look at how cell filters and custom aggregation functions interact with the column type. The issue is that adding type: 'number' fixes sorting but breaks aggregation; understand why and find a solution that maintains both. Check the main grid source files such as src/features/grouping and src/features/sort. Also consider the use of the cellFilter parameter in gridOptions.