angular-ui/ui-grid

enableFullRowSelection + allowCellFocus: false not preventing selection

Open

#5,380 opened on May 5, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Seen at http://ui-grid.info/docs/#/tutorial/210_selection

When enableFullRowSelection is true, allowCellFocus makes no difference.

Contributor guide

Research direction
Investigate the code where allowCellFocus interacts with enableFullRowSelection. Look for conditional checks that might be ignoring allowCellFocus when enableFullRowSelection is true. Check the selection handler and cell focus logic in the grid source.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Angular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70