angular-ui/ui-grid

Ability to disable preEval and refer to mutliple eneity fields in 'columnDef.field'

Open

#5,346 opened on Apr 22, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

I want to have fields like someProp || 'N/A', but the current preEval function turns it into something like row['eneity']['someProp || \'N/A\''], which is obviously broken.

In addition, if I want to refer to more than one property in the expression, I'll have to manually prefix row.entity., which is also not guaranteed to work.

Can a switch be added to allow "raw" expressions in field without preEval and the prefixing of row.entity. It might be necessary to provide a local variable to the expression (e.g. entity) which points to row.entity.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Angular basicsJavaScript expressionsFamiliarity with ui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the preEval function in the ui grid source code. Identify where row.entity prefix is added. Consider adding an option like `disablePreEval` or `rawField` in columnDef. Look at any linked PRs or comments for further clarification.