angular-ui/ui-grid

Ability to disable preEval and refer to mutliple eneity fields in 'columnDef.field'

Open

#5,346 opened on Apr 22, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wanted

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I want to have fields like someProp || 'N/A', but the current preEval function turns it into something like row['eneity']['someProp || \'N/A\''], which is obviously broken.

In addition, if I want to refer to more than one property in the expression, I'll have to manually prefix row.entity., which is also not guaranteed to work.

Can a switch be added to allow "raw" expressions in field without preEval and the prefixing of row.entity. It might be necessary to provide a local variable to the expression (e.g. entity) which points to row.entity.

Contributor guide

Research direction
Investigate the preEval function in the columnDef module and find where it processes the 'field' property. Consider adding a new option like 'enableRawField' that bypasses preEval and allows raw expressions. Also, provide a local variable 'entity' that references row.entity within the expression.
Tech stack
javascriptangular
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65