angular-ui/ui-grid

Small rowEditWaitInterval causes unwanted save with rowedit

Open

#5,224 opened on Mar 14, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
help wantedneeds: analysis

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It is important to set rowEditWaitInterval to 1 (the lowest available value).

Steps to reporoduce:

  1. Open plunker: http://plnkr.co/edit/ci2rADfto0N4xwdEggAQ?p=preview
  2. Try to edit any cell and navigate to cell on the right or left (don't leave the row). -- If you use arrow keys to navigate everything works fine - save does not occur. -- But if you use mouse (click to another editable cell in the given row) - save should not occur until you leave row, But it does.

It seems that interval is too low to determine that another cell in the row is being edited and grid assumes row was left and attempts to save.

Happens on IE 11 and Edge 13.

Contributor guide

Research direction
Investigate how rowEditWaitInterval is used in row editing logic, focusing on the difference between keyboard and mouse navigation when moving between cells. Check the event handlers for cell navigation (arrow keys vs click) and the save trigger mechanism.
Tech stack
javascriptangular
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitAngular
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60