angular-ui/ui-grid

uiGridValidateService clearError bug

Open

#5,201 opened on Mar 9, 2016

View on GitHub
 (1 comment) (1 reaction) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

clearError function when clearing the last error is not setting the $$invalid to false (or deleting the $$invalid). clearError should have this code at the end

if(Object.getOwnPropertyNames(rowEntity['$$errors' + colDef.name]).length === 0 {
       delete rowEntity['$$invalid' + colDef.name];
}

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptAngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is in `ui grid` repository, specifically in `clearError` function of `uiGridValidateService`. The provided fix suggests adding a condition to delete `$$invalid` property when errors list is empty. Look for the service code in `src/features/validate/`. Check the current state of the file as the repository may have evolved since 2016. The linked issue #5201 has no PR, so the fix is not implemented.