angular-ui/ui-grid

uiGridValidateService clearError bug

Open

#5,201 opened on Mar 9, 2016

View on GitHub
 (1 comment) (1 reaction) (1 assignee)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

clearError function when clearing the last error is not setting the $$invalid to false (or deleting the $$invalid). clearError should have this code at the end

if(Object.getOwnPropertyNames(rowEntity['$$errors' + colDef.name]).length === 0 {
       delete rowEntity['$$invalid' + colDef.name];
}

Contributor guide

Research direction
Inspect the clearError function and apply the fix to delete the $$invalid property when no errors remain.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75