angular-ui/ui-grid

Vertical scrollbar width is not calculated on zoom change

Open

#5,192 opened on Mar 7, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
Browser ChromeBrowser Firefoxhelp wanted

Description

Scrollbar width is calculated when grid is initialized via

Steps to reporoduce the bug:

  1. Open http://plnkr.co/edit/Jlx891kOcOX39c1t9EpL?p=preview ... so far so good, grid's last column is right near scrollbar image

  2. Zoom in (e.g. to 200%) and you can see there is a space between last column's end and scrollbar image

  3. Zoom out (e.g. 50%) and you can see that part of last column is behind vertical scrollbar image

Problem can be reproduced in Chrome or Firefox. In IE it works fine.

The problem is that: self.scrollbarWidth = gridUtil.getScrollbarWidth();

is called on initialization only. It has to be also handled when zoom is changed (window resize maybe?). Because scrollbar width may vary depending on zoom level.

Contributor guide

Tech stack
javascriptcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptFamiliarity with AngularJS directives
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that scrollbar width is computed once on initialization via gridUtil.getScrollbarWidth() and stored in self.scrollbarWidth. The fix should add a listener (e.g., window resize event) that recalculates the width when zoom changes. Look at how the grid initialization code calls getScrollbarWidth, and add an event handler to update it. The relevant file is likely in the core grid module, possibly 'ui grid.js' or similar. Consider using Angular's $window or native addEventListener.