angular-ui/ui-grid

Sorting a dropdown column with a filter does not work

Open

#5,173 opened on Feb 26, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

Related to issue #2808, when using a drop-down with a filter to show the editDropdownValueLabel instead of the editDropdownIdLabel, and we have sortCellFiltered: true set, ui-grid incorrectly passes a row entity to the filter instead of the context. This prevents us from getting information about the column definition, in order to sort by filtered values.

Please see Codepen demonstrating the issue here, and a partial workaround here.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJSUI Grid basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue describes a bug where sorting a dropdown column with a filter incorrectly passes a row entity instead of the context when 'sortCellFiltered: true' is set. Two Codepen links are provided: one demonstrating the bug and one with a partial workaround. The issue references #2808. To resolve, investigate the grid's sort logic and filter handling, particularly how the cell filter is called during sorting. Look at the source code for sorting and filtering interactions.