angular-ui/ui-grid

Use css flexbox to resize viewport, instead of watching gridwidth and gridheight

Open

#5,154 opened on Feb 22, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

Grid resize is very slow, and it doesn't give a good image to people using the grid. A way to reduce a lot of overload by removing watches is to change all resize logic to css flexbox by replacing most/all ng-style tags (very slow). This change will also help to activate again the scrollbars.AUTO flag which is the best option for scrollbars (as it removes the need of coding this checking on ui-grid controllers).

Contributor guide

Tech stack
javascriptcss
Domain
frontend
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsCSS flexbox
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the current resize logic in ui grid that uses ng style for width/height calculations. The goal is to replace these with CSS flexbox to improve performance. Look at the grid resize functionality in the source code, particularly any controllers or directives that handle grid dimensions. Test the new flexbox approach for viewport resizing.
Use css flexbox to resize viewport, instead of watching gridwidth and gridheight · angular-ui/ui-grid#5154 | Good First Issue