angular-ui/ui-grid

TreeNode $$treeLevel logic is wrong

Open

#5,147 opened on Feb 19, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

If you want A ....A.1 ....A.2 ....A.3 B ....B.1 ....B.2 C D E

there is currently no way to inform the grid that C above does not have, and will never have children, and should not be a row-header.

Currently, the only way to ensure an item is not a row header is to set the $$treeLevel = undefined. *This allows the following to pass: *{'ui-grid-tree-header-row': row.treeLevel > -1}

However... The problem with this is row C above will always be bolded. B.2 has $$treeLevel = undefined, is a child of B, so it's OK C has $$treeLevel = null, which makes it correctly not a child of B, BUT, internally, it gets wrongly assigned to row.treeLevel =1, or something... actually not sure how it's passing the test.

See Plunker Demo In this example, "Morgan Sanford", row 45, should not be bold, it has no children. And, setting "Toggle Expand No Children" only partly helps, because the row is still bolded.

Contributor guide

Tech stack
angularjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJS basicsui grid tree feature
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the tree level logic in ui grid, likely in the tree feature source files. Examine how $$treeLevel is set and used in determining row header behavior. The issue mentions a Plunker demo; reproduce the bug to understand the expected vs actual behavior. Look for existing tests related to tree grid.