angular-ui/ui-grid

Grid container grows automatically in IE with auto-resize

Open

#5,140 opened on Feb 19, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
Browser IEgood first issue

Description

Hello,

if using the auto-resize feature and the grid hasn't a fixed height (e.g. only min-height or a height in % is giving) then the container grows on every timeout (250ms) by 1 px in IE11. May older or newer Versions of the IE are affected.

You can see it here: http://plnkr.co/edit/QmURrAjrl68Ye6w0yXJS?p=preview

I found a fix for that: You can find it here: https://github.com/ECP-Black/ui-grid/commit/bd57fcc893815366c8c357c68ee527144dd7118b

If i should send a pull request, let me know it.

Greetings Dennis

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the commit at https://github.com/ECP Black/ui grid/commit/bd57fcc893815366c8c357c68ee527144dd7118b to see the proposed changes. Understand the auto resize mechanism in ui grid and verify the fix works. Ensure no regression for other browsers. Submit a pull request if the fix is acceptable.
Grid container grows automatically in IE with auto-resize · angular-ui/ui-grid#5140 | Good First Issue