angular-ui/ui-grid

Not able to toggle column moving on if grid initialized with column moving off

Open

#5,103 opened on Feb 11, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
grid-move-columnshelp wantedtype: enhancement

Description

I have an issue that is partly related to #4076.

I have a grid that allows moving some columns but I need it to start in a read-only state (and not allow moving columns or editing until the user clicks an edit link).

I have tried toggling the enableColumnMoving flag on both the gridOptions and columnDefs. I have tried doing it via the column.setPropertyOrDefault method and also updateColumnDef. I've tried using grid.refresh() after making the changes.

If the columns begin their life with enableColumnMoving=false, absolutely nothing seems to enable moving. If I initialize the grid with it set to true, I can turn it on and off but I can't find any reliable way to know when the grid is fully initialized so that I can turn the flag off (it needs to be read only initially).

Also, if I initialize the grid with column moving enabled and then disable it, it still allows the user to drag the columns. It seems that it just doesn't actually perform the move. I would like to see it actually turn off column moving so the user doesn't get the impression that they can move when they shouldn't be able to.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with AngularJSUnderstanding of ui grid configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the ui grid source code for how enableColumnMoving is handled during initialization and toggling. Look at the grid options lifecycle and how changes to column definitions are propagated. Check the related issue #4076 for context. The user reports that setting enableColumnMoving to false initially prevents subsequent enabling, and that disabling after initialization does not remove the drag UI. The fix likely involves ensuring the property change triggers a re render of column headers and drag handlers.
Not able to toggle column moving on if grid initialized with column moving off · angular-ui/ui-grid#5103 | Good First Issue