angular-ui/ui-grid

Adding a ng-dblclick on rows causes cell selection on mousedown

Open

#5,060 opened on Feb 3, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Hello,

I'm trying to trigger an action on a double click on a row. It works fine except that when I add the ng-dblclick directive on my row, it causes that cells are somehow "selected" (see the attached picture) when I do a mousedown on them.

image

The edit mode is disabled as the 'ui.grid.edit' module is not imported.

To add the double click I have customized the templateRow :

appScopeProvider: {
                    onDblClick : function(row, $event) {
                             $timeout.cancel($scope.selectTimer);
                            var url = '//google.com';
                           $window.open(url, "_blank", "height=600,width=800,toolbar=no,location=no,menubar=no,titlebar=no");
                         }
                    },

                //The row template is updated to add the dble click action 
                rowTemplate : $templateCache.get('ui-grid/ui-grid-row').replace("<div ", "<div ng-dblclick=\"grid.appScope.onDblClick(row, $event)\" "),

I cannot figure out where this is coming and if I replace ng-dblclick by "ondblclick", I don't have the cell selected.

Is this a bug or is there a way to disable this behavior ?

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS basicsEvent handling in AngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the interaction between ng dblclick directive and ui grid's cell selection mousedown handler. Look at how the row template is customized and how the grid's event listeners are attached. The workaround using ondblclick suggests the issue is specific to Angular's event handling. Examine files: src/features/edit/ui grid edit.js and templates/ui grid/ui grid row.html. Check existing issues or comments for similar solutions.
Adding a ng-dblclick on rows causes cell selection on mousedown · angular-ui/ui-grid#5060 | Good First Issue