angular-ui/ui-grid

uiGridValidateService.setValidator have newValue & oldValue param values reversed

Open

#5,059 opened on Feb 3, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I was testing the sample in Plunkr and printed the newValue and oldValue parameters. Their values have been reversed. "NewValue" is showing old value and vice versa. Below is documented function with 2 alert statements.

uiGridValidateService.setValidator('startWith', function(argument) { return function(newValue, oldValue, rowEntity, colDef) { if (!newValue) { return true; // We should not test for existence here } else { alert('newValue ' + newValue); alert('oldValue ' + oldValue); return newValue.startsWith(argument); } }; }, function(argument) { return 'You can only insert names starting with: "' + argument + '"'; }

);

  • Nishat.

Contributor guide

Research direction
Examine the uiGridValidateService.setValidator function to understand how newValue and oldValue are passed to the validator callback. Check if the parameters are swapped in the implementation.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptAngularJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70