angular-ui/ui-grid

Editing rows with 2+ expandable grids open = scroll jump

Open

#5,057 opened on Feb 2, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
grid-editgrid-infinite-scrollgrid-row-edithelp wantedtype: bug

Description

Plunkr

Steps to reproduce:expand rows with ids 0 and 1, then try to double click on row with id = 2 to edit it.

When trying to edit row id=2, the table jumps/scrolls, both cancelling the edit and sometimes moving the row out of the viewport. Additionally, scrolling past the two expanded rows causes the scrolling to jump.

I'm guessing this has something to do with virtualizing the expanded grids. Is there a way to turn off the virtualization of the expanded grid if this is the case?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic knowledge of AngularJSUnderstanding of UI Grid expansions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
The issue describes a scroll jump when editing rows with multiple expanded grids. A potential fix may involve examining the virtual scrolling logic in the grid to ensure scroll position is maintained when an inline row edit triggers a re render. Investigate the 'ui grid' source code focusing on the 'GridRow' and 'GridCell' components, and check the 'expandable' feature's interaction with virtual scrolling. The plunkr mentioned in the issue should be reproduced to identify the exact steps causing the scroll jump.