angular-ui/ui-grid

Grid selection display issue

Open

#5,040 opened on Jan 28, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Demonstrated by this plunker

Not sure if it is practical, but if you are showing selection option, and decide to set 0 rows to be displayed, the selection display gets messed up and shows too many.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Angular basicsJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is demonstrated in the provided Plunker link. The bug occurs when setting 0 rows to display while selection is enabled. To fix, investigate the selection display logic in the grid rendering code, likely in the selection feature files. Look for how the selection display count is computed and ensure it handles zero rows gracefully.