angular-ui/ui-grid

ui-grid-viewport too small with responsive components in the headers

Open

#5,036 opened on Jan 27, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issueneeds: analysis

Description

When a header has responsive components in it the header size increases and the space allocated to the rows is not increased during the call to colContainer.getViewportStyle(). A workaround is to add:

.ui-grid-viewport.ng-isolate-scope[style] {
    height: auto !important;
}

Version used was 3.0.7 installed from bower.

Contributor guide

Tech stack
javascriptcsshtml
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
CSSAngularJSCSS box modelui grid internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the `colContainer.getViewportStyle()` method in the ui grid source code to understand viewport height calculation. The issue indicates that header height changes are not reflected; examine if a proper fix can be implemented by recalculating the viewport height on header resize, possibly using the CSS workaround as a guide. Check the repository's layout directives for header and viewport components.