angular-ui/ui-grid

Close Menu Item Shows up in the middle of the menu options

Open

#4,969 opened on Jan 14, 2016

View on GitHub
 (3 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
a11yhelp wantedtype: bug

Description

The menu should be at the bottom of the menu list. This UI component only shows up when tabbing through the menu options.

This menu option should appear at the bottom of the menu. screen shot 2016-01-14 at 1 49 00 pm

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of AngularJSUnderstanding of CSS positioning
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the menu component template in the ui grid repository, likely in a directive such as 'uiGridMenu'. Focus on the rendering order of menu items and any CSS that affects positioning. Check if the close menu item is added separately and thus appears in the middle instead of at the end. Look at the template file 'gridMenuTemplate' and the associated controller logic.
Close Menu Item Shows up in the middle of the menu options · angular-ui/ui-grid#4969 | Good First Issue