angular-ui/ui-grid

Grid autoAdjustHeight missing PaginationControls Height

Open

#4,960 opened on Jan 13, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issue

Description

Hi,

When the function "autoAdjustHeight()" is called, if you have enabled PaginationControls, the PaginationControls height is not took into account for the total grid height.

So when you set minRowsToShow to X you only show arround X-1 element (depending on rows height).

I'm using bower-ui-grid v3.0.7

Thx for your help.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptAngularJSCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Locate the autoAdjustHeight function in the source code, likely in the grid core or utilities. Examine how the total height is computed and verify if PaginationControls height is omitted. Check any related commits or issues for context. Implement a fix to include the pagination height, and test with pagination enabled and minRowsToShow set.