angular-ui/ui-grid

Expand/collapse issue when grouping + filtering

Open

#4,915 opened on Dec 29, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wanted

Description

By following these steps on Tutorial 401, you can see a disconnect between rendered rows and the collapse/expand all icon:

  • Group rows by Age using the column header menu
  • Use the expand all icon to expand all rows
  • Search the Name for xyz and see all rows filtered out (hidden)
  • Clear that search and see all rows rendered again in a collapsed state
  • Note that the expand all icon is actually in a collapse all state

I would expect one of two scenarios:

  • When clearing xyz, all rows would be rendered again in their previous expanded/collapsed state
  • The collapse all icon would be properly displayed as an expand all icon

Based on my application requirements, I would must prefer that rows are rendered again in their previous state.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with AngularJSUnderstanding of ui grid grouping and filtering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue involves the expand/collapse icon state not syncing with actual row visibility after clearing a filter. Start by examining the grid's grouping and filtering event handlers in the source code (likely in 'Grid.js', 'Grouping.js', or 'Filtering.js'). Focus on how the expand/collapse state is updated when filters are applied and cleared. Check the existing comments on the issue for any suggested starting points or previous attempts.