angular-ui/ui-grid

minWidth does not work with percent values

Open

#4,912 opened on Dec 29, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)JavaScript (2,496 forks)batch import
good first issue

Repository metrics

Stars
 (5,395 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When entering the minWidth value of a given column, if the value is a percent, the grid will not render.

STEPS TO DUPLICATE

  1. Create a grid with columns (be sure minWidth is a property in at least one of them)
  2. Set the minWidth property to a percent value (must be a string value, i.e. '10%' and not 10%)
  3. Assuming everything else was done correctly, the grid will still not render (to verify this was done right, change the percent value to a number; if the grid renders properly in this instance, you presumably did everything else right).

Below is a link to a plunkr I made to demonstrate this (I basically took the tutorial plunkr from lesson 204 from the tutorial and changed the minWidth to 10% for the first column in app.js)

http://plnkr.co/edit/9kjMpGNtWKTAEbi1bOCe?p=preview

Analyzing the results with firebug, the following message came back in the console.

Error: Cannot parse column minWidth '10%' for column named 'name'

Contributor guide

Research direction
Examine the column definition parsing logic in the ui grid source code to identify where minWidth is parsed, and add handling for string percent values like '10%'.
Tech stack
angularjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75