angular-ui/ui-grid

GridRenderContainer.prototype.getMargin seems to to slowdown apps

Open

#4,909 opened on Dec 27, 2015

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedseverity: performance

Description

I profiled one of my apps with Batarang. i noticed that for a page with six smaller ui grid instances the GridRenderContainer.prototype.getMargin takes about 60% of the cpu time.

The method is called from a template:

$templateCache.put('ui-grid/uiGridRenderContainer', ...{ 'margin-left': colContainer.getMargin('left') + 'px', 'margin-right': colContainer.getMargin('right') + 'px' }...

The function loops over viewportAdjusters. Maybe it is worthwhile to optimize the method. For example, it filters out the adjustment results of many of the calls made:

if (adjustment.side && adjustment.side === side)

Such calls could be avoided. Or maybe there is a way to cache the margins and avoid the loop altogether.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptAngularJSPerformance profiling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the `getMargin` method in `GridRenderContainer` prototype. The method loops over `viewportAdjusters` and filters by side. Consider caching margins or optimizing the loop. Look at the template in `ui grid/uiGridRenderContainer` where `getMargin` is called twice for left and right. Check if `viewportAdjusters` can be filtered before iteration.