angular-ui/ui-grid

infinite scroll dataRemovedTop() and dataRemovedBottom() broken

Open

#4,904 opened on Dec 24, 2015

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
grid-infinite-scrollhelp wantedseverity: memory leakseverity: performance

Description

I'm using version 3.0.7 and Chrome browser Version 47.0.2526.106 (64-bit) for Mac OS X.

I was having problems with my own code. Whenever I try to 'trim' my in-memory grid data by calling dataRemovedTop() or dataRemovedBottom() a needLoadMoreDataTop data is always triggered.

However, then I took the example/demo code from the ui-grid.info site here: http://ui-grid.info/docs/#/tutorial/212_infinite_scroll and played with it and noticed the same issue was happening.

'trimming' data does not currently work properly.

Please let me know if you need anymore data points.

Contributor guide

Tech stack
javascriptangularhtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJSUI Grid basicsJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Reproduce the bug using the infinite scroll demo at http://ui grid.info/docs/#/tutorial/212 infinite scroll. Examine the grid data methods such as dataRemovedTop() and dataRemovedBottom() in the ui grid source code, likely in the grid controller or data service. Look for any recent commits or PRs mentioning this issue. The goal is to understand why trimming triggers needLoadMoreDataTop incorrectly and propose a fix.