angular-ui/ui-grid

Problems with cellnav module and ui-bootstrap dropdown components

Open

#4,890 opened on Dec 21, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuegrid-cellNavneeds: decision

Description

Hi!

I have a problem with using ui-bootstrap dropdown control inside a cell template of a ui-grid with cellnav enabled. The problem is that dropdown doesn't close when I click inside a grid. I believe this is because of the following call to evt.stopPropagation() in cellnav feature: https://github.com/angular-ui/ui-grid/blob/94a31149ca0282612d7dc85d87d2a68f2c12367c/src/features/cellnav/js/cellnav.js#L681

If I remove that call to evt.stopPropagation(); then it just works.

Contributor guide

Tech stack
javascriptangular
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptevent propagationAngularJS basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the evt.stopPropagation() call at src/features/cellnav/js/cellnav.js line 681. Understand why it was added (e.g., to prevent cell selection? review git history if available). Test that removing it fixes the dropdown not closing and does not break other cellnav behavior like keyboard navigation. Look for existing tests in the test suite related to cellnav and run them to ensure no regressions.
Problems with cellnav module and ui-bootstrap dropdown components · angular-ui/ui-grid#4890 | Good First Issue