angular-ui/ui-grid

Since that the treeView module uses treeBase module, saveState module is broken

Open

#4,742 opened on Nov 20, 2015

View on GitHub
 (10 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
good first issuegrid-groupinggrid-tree-viewtype: bug

Description

Hi,

I wanted to implement treeView on my grid, and i wanted to restore tree state after refreshing data.

In the saveState module, in saveTreeView and restoreTreeView functions, there is this condition : if ( !grid.api.treeView || !grid.options.saveTreeView ){ return {}; }

It seems obsolete since the treeView module uses treeBase module , isn't it ? If i remove the condition, of course i get this error log : TypeError: Cannot read property 'getTreeView' of undefined

I missed something or i'm true ?

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS knowledgeui grid module architectureJavaScript debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue is in the saveState module where the `saveTreeView` and `restoreTreeView` functions check for `grid.api.treeView`. Since treeView now uses treeBase, this condition is outdated. Investigate the treeBase module to understand the correct API. Look at the comments in the issue for further discussion on the fix.