angular-ui/ui-grid

Select all checkbox not clearing on filter change

Open

#4,739 opened on Nov 20, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,395 stars) (2,496 forks)batch import
Low-Pri Buggrid-selectionhelp wantedtype: bug

Description

As a user, for example, in the following plnkr I want to select all the people with ages 22 and 30. I would set filter in the age column to 30 and would mark all the displayed rows as selected. Next I would change the filter in the age column to 22 and would want to select all the displayed rows to add up the selection to the previous selection that I made.

http://plnkr.co/edit/Hh307ESEMB6n3vwd9GHU?p=preview

Observed behavior: The SelectAll checkbox remains selected on filter change. On clicking the checkbox, the checkbox is cleared and also clears the previously made selection.

Expected behavior: The SelectAll checkbox should get cleared if the rows currently displayed are not in selected state. Clicking the SelectAll checkbox again should select the currently displayed rows and should add up to the previous selection made.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
AngularJSUI Grid selectionFilter behavior
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The issue is about the SelectAll checkbox not being cleared when the filter changes and the displayed rows are not all selected. To fix, investigate the selection service (likely in src/features/selection) and the filter change event handling. Look for where the SelectAll state is set and ensure it updates when the displayed rows change due to filtering. The expected behavior is that the checkbox toggles based on the current visible rows' selection state.