angular-ui/ui-grid

gridApi.grouping.getGrouping().grouping causes never ending loop

Open

#4,736 opened on Nov 19, 2015

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (5,395 stars) (2,496 forks)batch import
help wantedseverity: performance

Description

Using the gridApi.grouping.getGrouping().grouping call in an ng-repeat to dispay a list of grouped columns causes a never ending loop. Any columns that are grouped will continue to repeat indefinitely. I have created a plunker to illustrated the issue. Group by any column in the plunker below to demonstrate the issue:

http://plnkr.co/edit/5AxA1Z9sJ3Urtq4ed7QJ?p=preview

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS knowledgeunderstanding of ng repeatfamiliarity with ui grid
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the gridApi.grouping.getGrouping() function in the ui grid source code (likely in src/features/grouping). The issue is that calling .grouping on the returned object creates an infinite digest loop in AngularJS's $digest cycle when used in an ng repeat. Look for circular references or getter methods that return new objects each time. The provided plunker (http://plnkr.co/edit/5AxA1Z9sJ3Urtq4ed7QJ) demonstrates the behavior. Check if the issue has been addressed in later commits or if there is a known workaround.